-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update copyright year #524
Update copyright year #524
Conversation
✔️ No visual differences introduced by this PR. View Playwright Report (note: open the "playwright-report" artifact) |
977d91b
to
08ad267
Compare
I believe the FSF recommends include each year in the copyright notice: https://www.gnu.org/licenses/gpl-howto.html And in general, copyright notices are supposed to at minimum list the year of creation. I.e., you are not really supposed to modify them, though you can add to them. I think it's fine to stick with it as it doesn't really add much burden.
Maybe... but I found it a little weird to do this when the project is a distinct fork. My understanding is that you must retain original copyright notices when you fork, and add your own. But dunno, maybe I'm being too anal. 😄 |
08ad267
to
26ff161
Compare
I'll update the dates to a year range then; the only burden is when someone has to copypaste it to a new file I suppose. Tbh I don't think I've ever read that link you shared, hence my suggestions not really being in line wtih it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you for making the change. 🙏
Updated copyright year to 2024. IMO it's easier to have it as a single year, the most recent year, rather than a year range as Yomichan had it; more consistent across all files.
I've also wondered a few times if the combined copyright of yomitan+chan should just be grouped into something like