Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update copyright year #524

Merged

Conversation

toasted-nutbread
Copy link

Updated copyright year to 2024. IMO it's easier to have it as a single year, the most recent year, rather than a year range as Yomichan had it; more consistent across all files.

I've also wondered a few times if the combined copyright of yomitan+chan should just be grouped into something like

Copyright (C) 2020-2022  Yomichan Authors et al.

@toasted-nutbread toasted-nutbread requested a review from a team as a code owner January 14, 2024 22:34
Copy link

github-actions bot commented Jan 14, 2024

✔️ No visual differences introduced by this PR.

View Playwright Report (note: open the "playwright-report" artifact)

@toasted-nutbread toasted-nutbread force-pushed the update-copyright-year-2024 branch from 977d91b to 08ad267 Compare January 15, 2024 16:46
@djahandarie
Copy link
Collaborator

IMO it's easier to have it as a single year, the most recent year, rather than a year range as Yomichan had it; more consistent across all files.

I believe the FSF recommends include each year in the copyright notice: https://www.gnu.org/licenses/gpl-howto.html And in general, copyright notices are supposed to at minimum list the year of creation. I.e., you are not really supposed to modify them, though you can add to them. I think it's fine to stick with it as it doesn't really add much burden.

I've also wondered a few times if the combined copyright of yomitan+chan should just be grouped into something like

Maybe... but I found it a little weird to do this when the project is a distinct fork. My understanding is that you must retain original copyright notices when you fork, and add your own.

But dunno, maybe I'm being too anal. 😄

@toasted-nutbread toasted-nutbread force-pushed the update-copyright-year-2024 branch from 08ad267 to 26ff161 Compare January 20, 2024 03:24
@toasted-nutbread
Copy link
Author

I'll update the dates to a year range then; the only burden is when someone has to copypaste it to a new file I suppose. Tbh I don't think I've ever read that link you shared, hence my suggestions not really being in line wtih it.

Copy link
Collaborator

@djahandarie djahandarie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for making the change. 🙏

@djahandarie djahandarie added this pull request to the merge queue Jan 20, 2024
Merged via the queue into yomidevs:master with commit ff5db2c Jan 20, 2024
6 checks passed
@djahandarie djahandarie added the kind/meta The issue or PR is meta label Jan 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/meta The issue or PR is meta
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants